feat(node-type-registry): strip membership_type from AuthzAppMembership#1061
Merged
pyramation merged 1 commit intomainfrom May 6, 2026
Merged
feat(node-type-registry): strip membership_type from AuthzAppMembership#1061pyramation merged 1 commit intomainfrom
pyramation merged 1 commit intomainfrom
Conversation
AuthzAppMembership is hardcoded to membership_type=1. Remove membership_type and entity_type from parameter_schema — they don't belong on an app-level-only type. For entity-scoped checks, use AuthzEntityMembership instead. Regenerated blueprint types.
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AuthzAppMembershipis hardcoded tomembership_type=1— it's an app-level-only check. Removemembership_typeandentity_typefrom itsparameter_schemasince they don't belong on this type.AuthzEntityMembershipinsteadpermission,permissions,is_admin,is_ownerThis makes the distinction between
AuthzAppMembership(app-level, no scope config) andAuthzEntityMembership(entity-scoped, takes entity_field + membership_type) unambiguous.Review & Testing Checklist for Human
membership_typetoAuthzAppMembershippolicies (constructive-db generators already hardcode type=1)Notes
Companion change needed in
constructive-db: hardcodemembership_type=1in the RLS parser/AST builder forAuthzAppMembershipso it ignores anymembership_typeparam even if passed.Link to Devin session: https://app.devin.ai/sessions/b4ff120294f446d8a0407ac21e05f7bb
Requested by: @pyramation